Re: Uniform branch coloring

From: Jeff King <peff@peff.net>
Date: Nov 30, 2011, 06:55 UTC
Message-ID: <20111130065540.GD5317@sigill.intra.peff.net>
In-Reply-To: <CA+TMmK=476h1YyVcegWia2F+1bhOQyNLf-150qF1bnU8Wu3qJA@mail.gmail.com>

On Thu, Nov 17, 2011 at 02:08:38PM -0500, Nicolas Dudebout wrote:

> I was looking at the coloring of git branches in the output of
> different commands and had an idea.
> It seems to me that the color coding for branches should be uniform throughout.

That sounds like a reasonable goal. At the very least all of the spots should be configurable, so you can make it uniform if you want to.

And then having unset config fallback to a "master" switch (e.g., if color.branch.current is unset, use color.default.branch or whatever). Which I think is close to what you write below.

> I have identified ways to address some of these problems:
> [...]

These all looked like reasonable goals to me. You will have to do a little refactoring, I'm sure.

> What are your thoughts on that?

Go for it. Your ideas sound sane. You might hit some ugly complexities in the implementation, but you won't know until you dig in and try. And patches are much easier to review (and apply!) than ideas. :)

-Peff