git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff and apply: fix singular/plural grammar nit.

From
Carlos Martín Nieto <cmn@elego.de>
Date
Nov 27, 2011, 14:50 UTC
Message-ID
<20111127145033.GA1738@centaur.lab.cmartin.tk>
In-Reply-To
<m37h2lmxk9.fsf@localhost.localdomain>
On Sun, Nov 27, 2011 at 06:47:21AM -0800, Jakub Narebski wrote:
Show 22 quoted lines
> David Ripton <dripton@ripton.net> writes:
> 
> > Remove the trailing 's' from "files", "insertions", and "deletions"
> > when there is only one of the item.
> > 
> > Signed-off-by: David Ripton <dripton@ripton.net>
> > ---
> [...]
> > -       printf(" %d files changed, %d insertions(+), %d
> > deletions(-)\n", files, adds, dels);
> 
> Whitespace damaged.  Please turn off word wrapping (limiting line
> width) when sending patches.
> 
> > +       printf(" %d file%s changed, %d insertion%s(+), %d deletion%s(-)\n",
> > +              files, (files == 1 ? "" : "s"),
> > +              adds, (adds == 1 ? "" : "s"),
> > +              dels, (dels == 1 ? "" : "s"));
> >   }
> 
> First, I think this is an API / plumbing and should not be changed.
> But I might be mistaken about that.

I think somebody already tried to do this not too long ago (don't know if there as a patch) but the diffstat tool always uses the plural, and it might break scripts.

   cmn
Previous: Jakub NarebskiNext: Frans Klaver
Message 3 of 4 in “diff and apply: fix singular/plural grammar nit.”
  1. diff and apply: fix singular/plural grammar nit.David Ripton, Nov 27, 2011
  2. Jakub NarebskiNov 27, 2011
  3. Carlos Martín NietoNov 27, 2011
  4. Frans KlaverNov 27, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.