Re: Incremental use of fast-import may cause conflicting notes

From

Jonathan Nieder <jrnieder@gmail.com>

Date

Nov 24, 2011, 23:09 UTC

Message-ID

<20111124230917.GC27586@elie.hsd1.il.comcast.net>

In-Reply-To

<Pine.GSO.4.63.1111231137350.5099@shipon.roxen.com>

Hi Henrik,

Henrik Grubbström wrote:

> Background: I have an incremental repository-walker creating a corresponding
> documentation repository from a source repository
> that uses git-notes to store its state, a use for which notes
> seem very suitable.

Nice.

[...]

> when fast-import is restarted
> it won't remember the fanout, and will start writing files in the root
> again. This means that there may be multiple notes-files for the same
> commit, eg both de/adbeef and deadbeef.

[...]

> The problem is probably due to b->num_notes not being initialized properly
> when the old non-empty root commit for the notes branch is loaded in
> parse_from()/parse_new_commit().

Thanks.