Re: [PATCH] i18n: add infrastructure for translating Git with gettext

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Nov 16, 2011, 10:33 UTC
Message-ID: <20111116103319.GB30753@elie.hsd1.il.comcast.net>
In-Reply-To: <CACBZZX4nypBW1agNw6NrC-7LBWbjZ1ycgpn-zvBsg0x4EDBD0g@mail.gmail.com>

Ævar Arnfjörð Bjarmason wrote:

Show 8 quoted lines

> Here's what we do with the sharedir currently:
>
>  * It's used as the gitwebdir already, and is used also as the
>    localedir with this patch:
>
>     sharedir = $(prefix)/share
>     gitwebdir = $(sharedir)/gitweb
>     localedir = $(sharedir)/locale

This has $(prefix)/ (e.g., /usr/) at the start.

Show 5 quoted lines

>  * Even then I can't find the option that makes gitweb put something
>    in it, after a "make" with this patch:
>
>     $ find share -type f
>     share/locale/is/LC_MESSAGES/git.mo

This does not.

Show 8 quoted lines

>  * It *is* important that we have this under a
>    $SOMETHING/is/LC_MESSAGES/git.mo structure, since we set
>    GIT_TEXTDOMAINDIR to $SOMETHING, and the gettext library will only
>    understand something in this layout.
>
>    But that $SOMETHING doesn't have to be $ROOT/share, it could be
>    e.g. $ROOT/po/generated, which would make it not conflict with the
>    gitwebdir.

Yeah, makes sense. bin-wrappers/git has to get its locales from somewhere.