Re: [PATCH 0/2] upload-archive security issues

From: Jeff King <peff@peff.net>
Date: Nov 15, 2011, 22:23 UTC
Message-ID: <20111115222320.GA28646@sigill.intra.peff.net>
In-Reply-To: <CABPQNSZ71==pQvH9nTQ3rD6c1RJiLmkA+k_9KS=T45cQb+PTLA@mail.gmail.com>

On Tue, Nov 15, 2011 at 11:01:09PM +0100, Erik Faye-Lund wrote:

> Yikes! Perhaps the whole deal of rewriting the code to take explicit
> file descriptors (and/or dup-bonanza) would have been the better
> choice after all?

It's certainly simpler. This way is not that hard to fix; we just need to be more careful about the code path getting from upload-archive into write_archive.

> For the record: I would be fine with c09cd77e simply being reverted
> for this release, and having a better version applied in the near
> future. Windows support for upload-archive is not worth the risk of
> slipping in a remote code execution bug...

I'd be OK with that, too.

Show 6 quoted lines

> Not only did you fail to spot them, you actually wrote that part of the code ;)
> 
> http://article.gmane.org/gmane.comp.version-control.git/178098
> 
> (I don't mean to shift blame over to you, I'm the one who should have
> spent more time thinking about this as this was "my" series)

Heh. I did say "something like this" in that message, which is usually a sure sign I haven't actually thought too hard about the code I'm about to write. I'll be content to share the blame equally with you. :)

-Peff