git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/4] refresh_index: notice typechanges in output

From
Jeff King <peff@peff.net>
Date
Nov 15, 2011, 02:05 UTC
Message-ID
<20111115020506.GA6305@sigill.intra.peff.net>
In-Reply-To
<7vaa7yi6wv.fsf@alter.siamese.dyndns.org>
On Mon, Nov 14, 2011 at 04:08:32PM -0800, Junio C Hamano wrote:
> I agree that we should not say that an intent-to-add entry has changed
> type relative to whatever, as by definition there is nothing to compare
> against. "A" that stands for "A"dd is a lot more sensible here, I would
> think.
Yeah, that makes sense to me.
> +			if (cache_errno == ENOENT)
> +				fmt = deleted_fmt;
> +			else if (ce->ce_flags & CE_INTENT_TO_ADD)
> +				fmt = added_fmt; /* must be before other checks */

Thanks, I was trying to figure out how to tell an intent-to-add file from the 'changed' flag, but obviously looking for the bit in the cache entry is the right thing.

Do you want to add your patch on top, or do you want me to re-roll with this squashed in? I can also hold the re-roll until post-release if you want.

-Peff
Previous: Junio C HamanoNext: Jeff King
Message 13 of 18 in “reset reports file as modified when it's in fact deleted”
  1. Carlos Martín NietoNov 7, 2011
  2. Jeff KingNov 7, 2011
  3. Carlos Martín NietoNov 11, 2011
  4. Junio C HamanoNov 11, 2011
  5. Jeff KingNov 11, 2011
  6. Junio C HamanoNov 12, 2011
  7. Jeff KingNov 14, 2011
  8. 1/4 refresh_index: rename format variablesJeff King, Nov 14, 2011
  9. 2/4 refresh_index: mark deletions in porcelain outputJeff King, Nov 14, 2011
  10. 3/4 read-cache: let refresh_cache_ent pass up changed flagsJeff King, Nov 14, 2011
  11. 4/4 refresh_index: notice typechanges in outputJeff King, Nov 14, 2011
  12. Junio C HamanoNov 15, 2011
  13. Jeff KingNov 15, 2011
  14. Jeff KingNov 18, 2011
  15. 1/3 read-cache: let refresh_cache_ent pass up changed flagsJeff King, Nov 18, 2011
  16. 2/3 refresh_index: rename format variablesJeff King, Nov 18, 2011
  17. 3/3 refresh_index: make porcelain output more specificJeff King, Nov 18, 2011
  18. Junio C HamanoNov 18, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.