Re: [PATCH] svn: Create config options for common args

From: Eric Wong <normalperson@yhbt.net>
Date: Nov 14, 2011, 21:46 UTC
Message-ID: <20111114214602.GA22399@dcvr.yhbt.net>
In-Reply-To: <1321302310-28793-1-git-send-email-ted.percival@quest.com>

Ted Percival <ted.percival@quest.com> wrote:

>  Documentation/git-svn.txt |   10 ++++++++++

Thanks, documentation part is very much appreciated

Show 9 quoted lines

> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -21,6 +21,9 @@ $Git::SVN::default_repo_id = 'svn';
>  $Git::SVN::default_ref_id = $ENV{GIT_SVN_ID} || 'git-svn';
>  $Git::SVN::Ra::_log_window_size = 100;
>  $Git::SVN::_minimize_url = 'unset';
> +$Git::SVN::_localtime = Git::config_bool('svn.localtime');
> +$Git::SVN::_add_author_from = Git::config_bool('svn.addAuthorFrom');
> +$Git::SVN::_use_log_author = Git::config_bool('svn.useLogAuthor');

I don't think these are needed. The read_git_config() function /should/ be checking all GIT_CONFIG equivalents of the Getopt::Long option specs. Can you verify? Thanks.