Re: [PATCH] fsck: print progress
- From
Jeff King <peff@peff.net>
- Date
- Nov 3, 2011, 20:29 UTC
- Message-ID
- <20111103202954.GC19483@sigill.intra.peff.net>
- In-Reply-To
- <7v8vnxeyrp.fsf@alter.siamese.dyndns.org>
On Thu, Nov 03, 2011 at 01:28:42PM -0700, Junio C Hamano wrote:
Show 15 quoted lines
> Jeff King <peff@peff.net> writes: > > >> Hmm, once you do this kind of thing I would expect two (or more) progress > >> bars to be shown, something like: > >> > >> $ git fsck --progress > >> checking packs: 3 of 7 (42% done) > >> checking objects in pack: 12405 of 332340 (4% done) > > > > I don't think we can do multiple lines portably, though, because the > > progress code just uses "\r" to return to the beginning of the line. > > It was meant to be a tongue-in-cheek comment. I personally hate those > "Installing n of N packages / Installation of package n p% done" progress > meters when we know the weight of each of these N packages varies.
OK, I missed your sarcasm. You're too understated. ;)
So you would agree that we are better summing the objects for all packs and showing one big progress bar?
-Peff