Re: [PATCH] git-svn: add hook to allow modifying the subversion commit message

From: Eric Wong <normalperson@yhbt.net>
Date: Nov 1, 2011, 20:28 UTC
Message-ID: <20111101202806.GB29769@dcvr.yhbt.net>
In-Reply-To: <1319228708-9052-1-git-send-email-michi@icosahedron.de>

Michael Lutz <michi@icosahedron.de> wrote:

Show 8 quoted lines

> Sometimes modifying the commit message git-svn creates for a subversion
> commit can be useful, for example if the original message contains meta
> information not needed in the git clone or information from svn properties
> should be stored visibly in the commit message.
> 
> This change adds a hook 'git-svn-msg' analogue to the 'commit-msg' hook.
> Additionally to the commit message, the hook is passed the git-svn meta
> data by an environment variable.

I'm not convinced this is a good feature to support. We already have --no-metadata to remove git-svn-id: lines and I hate that feature because it introduced extra variables for testing/debugging/recovery.

Metadata in the commit message is important, if you want to remove it after-the-fact, there's git-filter-branch.

When dealing with repositories that have been through several systems (e.g. (CVS|Perforce) -> SVN -> git), it's useful to be able to refer to old mailing list archives that only refer to the original system (since neither SVN nor git existed at the time the email was sent).