Re: [PATCH v2] completion: fix issue with process substitution not working on Git for Windows
- From
- Jonas Berlin <jonas.berlin@outerspace.dyndns.org>
- Date
- Oct 27, 2011, 10:40 UTC
- Message-ID
- <20111027134043.56519ca4@outerspace.dyndns.org>
- In-Reply-To
- <20111027132754.1503b98b@outerspace.dyndns.org>
On Thu, 27 Oct 2011 13:27:54 +0300 Jonas Berlin <xkr47@outerspace.dyndns.org> wrote:
Show 13 quoted lines
> On Thu, 27 Oct 2011 11:05:30 +0200 > SZEDER Gábor <szeder@ira.uka.de> wrote: > > The $output variable is not declared as local and therefore it leaks > > into the environment. But instead of declaring it local, why not > > eliminate it altogether, and use the "$(git config ....)" command > > substitution as here string? > > Wouldn't this work: > > git config -z --get-regexp '^(svn-remote\..*\.url|bash\.showupstream)$' 2>/dev/null | tr '\0\n' '\n ' | \ > while read key value; do > ... > done
Sorry, please disregard, I didn't notice it was already dismissed in v1 of the PATCH..
- xkr47