Re: Possible diff regression in v1.7.6-473-g27af01d

From: Thomas Rast <trast@student.ethz.ch>
Date: Oct 24, 2011, 09:38 UTC
Message-ID: <201110241138.51448.trast@student.ethz.ch>
In-Reply-To: <1319448227.70497.YahooMailNeo@web29402.mail.ird.yahoo.com>

Franz Schrober wrote:

Show 7 quoted lines

> Hi,
> 
> I am using git to manage some patches on top of the actual upstream files, but noticed that the result of git-format-patch changed between 4bfe7cb6668c43c1136304bbb17eea1b3ddf0237 and 27af01d552331eacf1ed2671b2b4b6ad4c268106
> 
> I've attached two input files (I tried to provide a minimal example... I am not sure if a smaller example is possible but at least both files are smaller than 10 lines) and the results with version 1.7.6.3 and and 1.7.7. The diffs were created using: git diff anonymized_orig anonymized_new
> 
> My .gitconfig file is empty.

I'm not sure why you call this a regression. For the benefit of people who hate saving attachments, you used

  $ paste anonymized_orig anonymized_new  | xclip
  0       1
  0       2
  0       0
  0       3
          4
          5
          6
          7

the old diff was

  --- a/anonymized_orig
  +++ b/anonymized_new
  @@ -1,4 +1,8 @@
  -0
  -0
  -0
  -0
  +1
  +2
  +0
  +3
  +4
  +5
  +6
  +7

and the new diff is

  --- a/anonymized_orig
  +++ b/anonymized_new
  @@ -1,4 +1,8 @@
  +1
  +2
   0
  -0
  -0
  -0
  +3
  +4
  +5
  +6
  +7
 
So the new diff correctly represents the change, and on top of that is
shorter (by only one line, admittedly).  What makes it a regression?

-- 
Thomas Rast
trast@{inf,student}.ethz.ch