Re: [IGNORETHIS/PATCH] Choosing the sha1 prefix of your commits
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Oct 19, 2011, 22:09 UTC
- Message-ID
- <20111019220931.GA8322@elie.hsd1.il.comcast.net>
- In-Reply-To
- <CACBZZX5PqYa0uWiGgs952rk2cy+QRCU95kF63qzSi3fKK-YrCQ@mail.gmail.com>
Ævar Arnfjörð Bjarmason wrote:
Show 6 quoted lines
> Someone asked me if having a "lulz" header wouldn't > break things, but since we introduced the "encoding" header a while > back clients have learned to ignore unknown headers, so it doesn't. > > Which is why we can discuss e.g. adding GPG headers without worrying > about breaking everything.
Just for the record (and I think you understood this already): it is not quite so simple. Clients are allowed to assume that no "unknown" header lines will appear before any of the known fields. A future git version could even assume that, say, a
length-of-remainder-of-header
field appears before any lines after encoding and the GPG stuff.
So it would definitely be frowned upon to add new lines to that part of the commit object without at least discussing it on this list. Jeff mentioned one way to get your lulz without violating that constraint. ;-)
http://thread.gmane.org/gmane.comp.version-control.git/138848/focus=138921