Re: regression in git-gui since 2c5c66b... Merge branch 'jp/get-ref-dir-unsorted

From: Jeff King <peff@peff.net>
Date: Oct 17, 2011, 13:55 UTC
Message-ID: <20111017135501.GA4171@sigill.intra.peff.net>
In-Reply-To: <4E9C2F3C.7080405@alum.mit.edu>

On Mon, Oct 17, 2011 at 03:35:56PM +0200, Michael Haggerty wrote:

Show 12 quoted lines

> On 10/17/2011 12:07 PM, Mark Levedahl wrote:
> > Your modification of my script does not show the error for me, unless I
> > have *installed* a version of git with the failure: I suspect git-gui
> > invokes installed components, and not what is in the build directory, so
> > having a good version of git installed with the bad version in the build
> > directory does not show the error. And yes, I am quite sure that all of
> > the git commands I am running are from the one version.
> 
> Yes, you seem to be right.  Even if I set PATH to list my git build
> directory before the directory where it is installed, "git-gui"
> sometimes invokes git-rev-parse from the libexec path of the installed
> version.

If you are testing directly out of the build directory, you need to set GIT_EXEC_PATH, too. The bin-wrappers/git script will do this for you (and is what the test scripts use).

But note that there's a catch with git-gui, as its built version doesn't live in the top-level. So running:

  bin-wrappers/git gui

will try to exec the git-gui directory. You can work around it with:

  bin-wrappers/git gui/git-gui

-Peff