Re: What's cooking in git.git (Oct 2011, #05; Fri, 14)

From: Jeff King <peff@peff.net>
Date: Oct 16, 2011, 16:53 UTC
Message-ID: <20111016165329.GA14226@sigill.intra.peff.net>
In-Reply-To: <7vd3dzximu.fsf@alter.siamese.dyndns.org>

On Fri, Oct 14, 2011 at 04:23:21PM -0700, Junio C Hamano wrote:

Show 5 quoted lines

> * jk/pull-rebase-with-work-tree (2011-10-13) 1 commit
>  - pull,rebase: handle GIT_WORK_TREE better
> 
> Looked reasonable.
> Will merge to 'next'.

I'm not so sure. Didn't you demonstrate that cd_to_toplevel as-is will not actually go to the toplevel if we're outside of the work tree?

And changing it is non-trivial, because there may be weird cases that rely on staying there? See my final note in the thread:

  http://article.gmane.org/gmane.comp.version-control.git/183519

> * jk/daemon-msgs (2011-10-14) 1 commit
>  - daemon: give friendlier error messages to clients
> 
> Will merge to 'next'.

I'm happy to tweak the "access denied" message if other people want. I kind of hoped it wouldn't matter, and that most sites would use --informative-errors.

-Peff