Re: [BUG] remote-curl.c: honor pushurl

From: Jeff King <peff@peff.net>
Date: Oct 14, 2011, 15:48 UTC
Message-ID: <20111014154853.GA10722@sigill.intra.peff.net>
In-Reply-To: <4E985744.6050904@elegosoft.com>

On Fri, Oct 14, 2011 at 05:37:40PM +0200, Michael Schubert wrote:

Show 15 quoted lines

> When doing a push (fetch, ..) over http(s), git calls git-remote-http to
> communicate with the server.
> 
> 	git-remote-http <remote> [<url>]
> 
> Git correctly honors a configured pushurl and passes it to git-remote-http,
> but git-remote-http is initiating the http connection with the url defined
> for remote (remote->url) rather than the passed url. This undermines the
> purpose of a config like
> 
> 	url = https://example.com/repo.git
> 	pushurl = https://user@example.com/repo.git
> 
> Introduced around 888692b7 - CC'ing Tay Ray Chuan. (I don't know if it was
> working before, though.)

Already noticed and fixed last week.

See this thread, starting at the focused message.

  http://thread.gmane.org/gmane.comp.version-control.git/182752/focus=182872

-Peff