git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 6/6] revert: Simplify passing command-line arguments around

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Oct 9, 2011, 08:53 UTC
Message-ID
<20111009085306.GA9209@elie.hsd1.il.comcast.net>
In-Reply-To
<CALkWK0kA=zhpsmYhjMwv11xyHNhA0Ps=BjUDao0+HFLMKnADUg@mail.gmail.com>
Ramkumar Ramachandra wrote:
> Actually, I intended to put it in the commit message.  Seems to be
> idiomatic: grep the log for "\[jc:" etc.

More important than the idiom is the intent. Presumably that intent was something like "I wrote the commit message, so if it makes you scratch your head, blame me, not Jonathan; and I made some other (minor) improvements, so consider blaming me even if it's the functional part that makes you scratch your head."

Sorry I haven't had a chance to look over the patch yet. Is it supposed to introduce a behavior change, does it prepare for some future change, or is it just a cleanup?

Previous: Ramkumar RamachandraNext: Ramkumar Ramachandra
Message 13 of 16 in “Sequencer fixups mini-series”
  1. 0/6 Sequencer fixups mini-seriesRamkumar Ramachandra, Oct 8, 2011
  2. 1/6 revert: Free memory after get_message callRamkumar Ramachandra, Oct 8, 2011
  3. 2/6 revert: Simplify getting commit subjectRamkumar Ramachandra, Oct 8, 2011
  4. 3/6 revert: Fix buffer overflow in insn sheet parserRamkumar Ramachandra, Oct 8, 2011
  5. 4/6 revert: Make commit descriptions in insn sheet optionalRamkumar Ramachandra, Oct 8, 2011
  6. Junio C HamanoOct 10, 2011
  7. Junio C HamanoOct 12, 2011
  8. Ramkumar RamachandraOct 17, 2011
  9. 5/6 revert: Allow mixed pick and revert instructionsRamkumar Ramachandra, Oct 8, 2011
  10. 6/6 revert: Simplify passing command-line arguments aroundRamkumar Ramachandra, Oct 8, 2011
  11. Tay Ray ChuanOct 9, 2011
  12. Ramkumar RamachandraOct 9, 2011
  13. Jonathan NiederOct 9, 2011
  14. Ramkumar RamachandraOct 9, 2011
  15. Jonathan NiederOct 9, 2011
  16. Ramkumar RamachandraOct 17, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.