Re: [PATCH/RFCv4 1/4] Documentation: Preparation for gitweb manpages

From: Jakub Narebski <jnareb@gmail.com>
Date: Sep 20, 2011, 00:10 UTC
Message-ID: <201109200210.13772.jnareb@gmail.com>
In-Reply-To: <20110919233703.GF6343@elie>

Thanks a lot for all language fixes.

Nb. I'll respond to other comments separately.

On Tue, 20 Sep 2011, Jonathan Nieder wrote:

> Jakub Narebski wrote:

Show 7 quoted lines

> > This way to build gitweb documentation one can use
> >
> >   make -C gitweb doc
> >
> > or
> >
> >   cd gitweb; make doc

Actually it should read "to build only gitweb documentation"...

Show 14 quoted lines

> Does "make -CDocumentation man html" build the gitweb documentation,
> too (and "make install-doc" install it)?
> 
> [...]
> > --- a/Documentation/Makefile
> > +++ b/Documentation/Makefile
> > @@ -170,6 +170,9 @@ info: git.info gitman.info
> >  
> >  pdf: user-manual.pdf
> >  
> > +GITWEB_DOC = $(filter gitweb.%,$(DOC_HTML) $(DOC_MAN1) $(DOC_MAN5) $(DOC_MAN7))
> > +gitweb-doc: $(GITWEB_DOC)
> 
> Looks like no, alas.

... because of the fact that gitweb.txt is in DOC_MAN1, and gitweb.conf.txt is in DOC_MAN5, then 'make doc' would among others build gitweb documentation. 'make -C Documentation gitweb-doc' / 'make -C gitweb doc' just builds a _subset_ of said documentation.

> 
> Except for that detail, this looks good.

Nb. what is also missing is having links to gitweb(1) and gitweb.conf(5) in git(1) manpages together with the rest.

-- 
Jakub Narebski
Poland