git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: gitk: 'j' and 'k' keyboard shortcuts backward

From
Josh Triplett <josh@joshtriplett.org>
Date
Sep 19, 2011, 17:11 UTC
Message-ID
<20110919171156.GA1705@leaf>
In-Reply-To
<20110919164950.GB2861@elie>
On Mon, Sep 19, 2011 at 11:49:50AM -0500, Jonathan Nieder wrote:
Show 20 quoted lines
> How about this patch?
> 
> -- >8 --
> Subject: gitk: Make vi-style keybindings more vi-like
> 
> When commit 6e2dda35 (Add new keybindings, 2005-09-22) added vi-style
> keybindings to gitk (an excellent idea!), instead of adopting the
> usual "hjkl = left, down, up, right" bindings used by less, vi, rogue,
> and many other programs, it used "ijkl = up, left, down, right" to
> mimic the inverted-T formation of the arrow keys on a qwerty keyboard,
> in the style of Lode runner.  So using 'j' and 'k' to scroll through
> commits produces utterly confusing results to the vi user, as 'k'
> moves down and 'j' moves to the previous commit.
> 
> Luckily most non-vi-users are probably using an alternate set of keys
> (cursor keys or z/x + n/p) anyway.  Switch to the expected vi/nethack
> convention.
> 
> Requested-by: Josh Triplett <josh@joshtriplett.org>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
This looks perfect to me.
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Thanks!
- Josh Triplett
Previous: Jonathan NiederNext: Clemens Buchacher
Message 2 of 5 in “Re: gitk: 'j' and 'k' keyboard shortcuts backward”
  1. Jonathan NiederSep 19, 2011
  2. Josh TriplettSep 19, 2011
  3. Clemens BuchacherSep 19, 2011
  4. Klaus Robert SuetterlinSep 19, 2011
  5. Paul MackerrasOct 8, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.