Re: Problems with format-patch UTF-8 and a missing second empty line

From: Jeff King <peff@peff.net>
Date: Sep 15, 2011, 18:50 UTC
Message-ID: <20110915185033.GA17016@sigill.intra.peff.net>
In-Reply-To: <20110915224456.14410ed8@zappedws>

[resending with git@vger cc'd; please keep discussion on list]

On Thu, Sep 15, 2011 at 10:44:56PM +0400, Alexey Shumkin wrote:

Show 19 quoted lines

> > On Thu, Sep 15, 2011 at 11:45:15AM +0200, Ingo Ruhnke wrote:
> > 
> > > Creating a patch of a commit including UTF-8 and no empty second
> > > line, like this:
> > > [...]
> > > Results in this:
> > > [...]
> > > Subject: [PATCH] =?UTF-8?q?=C3=84=C3=96=C3=9C
> > > =20=C3=84=C3=96=C3=9C?=
> > >[....]
> > > The problems happen with git version 1.7.4.1 (4b5eac7f0) on Ubuntu
> > > 11.04.
> > 
> > I'm pretty sure I fixed this in a1f6baa, which is in v1.7.4.4 and
> > later.
> 
> I reproduced this bug with the latest git (v1.7.6.3)
> It seems to me this is not the "git format-patch" bug
> but "git am"'s one. (But it is only the supposition)

Can you be more specific about what you tested? Running Ingo's snippet with a more recent git produces:

  Subject: [PATCH] =?UTF-8?q?=C3=84=C3=96=C3=9C=20=C3=84=C3=96=C3=9C?=

which is right (and "git am", new or old, will apply it just fine).

But there may be a different, related bug lurking somewhere.

-Peff