[nit] diff func headers ignore context

From: Jeff King <peff@peff.net>
Date: Sep 13, 2011, 22:04 UTC
Message-ID: <20110913220421.GA24549@sigill.intra.peff.net>
In-Reply-To: <20110913215824.GG24490@sigill.intra.peff.net>

On Tue, Sep 13, 2011 at 05:58:25PM -0400, Jeff King wrote:

Show 6 quoted lines

> @@ -609,26 +610,23 @@ int finish_async(struct async *async)
>  int run_hook(const char *index_file, const char *name, ...)
>  {
>  	struct child_process hook;
> -	const char **argv = NULL, *env[2];
> +	struct argv_array argv = ARGV_ARRAY_INIT;

I find this diff function header pretty confusing. Of course we're not in finish_async, as you can see by the fact that the context contains the start of run_hook.

I don't think this is something that can be solved with xfuncname config; we would have to teach xdiff to look at context lines when picking a header line.

Am I the only one who finds this confusing? Can anyone think of a reason to keep showing finish_async in this example?

-Peff