git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC 1/2] format-patch: demonstrate that color.ui=always produces colorized patches

From
Jeff King <peff@peff.net>
Date
Sep 12, 2011, 16:58 UTC
Message-ID
<20110912165811.GB8054@sigill.intra.peff.net>
In-Reply-To
<1315843016-10959-2-git-send-email-pangyanhan@gmail.com>
On Mon, Sep 12, 2011 at 11:56:55PM +0800, Pang Yan Han wrote:
> Hi, I don't know if I actually understand the naming convention for tests
> correctly here, so I used the next available number for the last 2 digits.
> 
>  t/t4051-format-patch-color.sh |   23 +++++++++++++++++++++++

Usually we would try to keep format-patch tests clustered numerically, but it seems the t40* space has gotten quite filled up and fragmented. So I think where you added it is fine (and if somebody cares to reorganize tests, they can do so later).

Often if there is only one or two tests to add, it is more logical to add to an existing script. However, I think in this case, starting a new script to check how format-patch handles various config features (including color) makes sense. Maybe it makes sense to call it "format-patch-config" instead, and set the description to something like "check that format-patch does not respect porcelain config".

-Peff
Previous: Pang Yan HanNext: Pang Yan Han
Message 3 of 5 in “format-patch: produce non colorized patches when color.ui=always”
  1. 0/2 format-patch: produce non colorized patches when color.ui=alwaysPang Yan Han, Sep 12, 2011
  2. 1/2 format-patch: demonstrate that color.ui=always produces colorized patchesPang Yan Han, Sep 12, 2011
  3. Jeff KingSep 12, 2011
  4. 2/2 format-patch: produce non colorized patches when ui.color=alwaysPang Yan Han, Sep 12, 2011
  5. Jeff KingSep 12, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.