Re: "git archive" seems to be broken wrt zip files

From: Jeff King <peff@peff.net>
Date: Sep 11, 2011, 06:22 UTC
Message-ID: <20110911062206.GA29620@sigill.intra.peff.net>
In-Reply-To: <CA+55aFx43OxExGNrJs+AyKNtdr+KCZZoE=iaQTz8uHoUSrQv0w@mail.gmail.com>

On Sat, Sep 10, 2011 at 09:58:08PM -0700, Linus Torvalds wrote:

Show 10 quoted lines

> So I wouldn't ever have noticed on my own, but now that I've tried
> github for the kernel, somebody else reported that the downloaded zip
> file (seriously? the kernel as a zip file?) is corrupt.
> 
> And it doesn't really seem to be a github issue. I can re-create it
> with a simple
> 
>    git archive --format=zip HEAD -o ../kernel.zip
> 
> on my kernel repository: the end result does not unzip correctly:

Hmm. I can easily replicate the problem here, but interestingly it does not happen with sub-trees like:

  git archive --format=zip HEAD:drivers -o ../kernel.zip

Going back in history, I can replicate it with René's 62cdce1 (git-archive --format=zip: add symlink support, 2006-10-07). So there's nothing to bisect.

Cc'ing René.

-Peff