git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] remote: "rename o foo" should not rename ref "origin/bar"

From
Jeff King <peff@peff.net>
Date
Sep 2, 2011, 15:55 UTC
Message-ID
<20110902155521.GA19690@sigill.intra.peff.net>
In-Reply-To
<alpine.DEB.2.00.1109012022110.7267@debian>
On Thu, Sep 01, 2011 at 08:35:01PM -0400, Martin von Zweigbergk wrote:
Show 11 quoted lines
> > To be totally correct, shouldn't this check each ref against the RHS of
> > the remote's old refspec, and rename it according to the remote's new
> > refspec?
> 
> That's what I thought too, but was planning on leaving it for a
> separate patch. However, after changing patch 1 to only update the
> fetch refspecs from "refs/remotes/$OLD" to "refs/remotes/$NEW", there
> is no other place in the fetchspec where a remote name can occur and
> 'git remote rename' still understands it. So since we're now being
> more conservative about updating refspecs, I guess we need to be
> equally conservative about updating ref names.

Yeah, I think with the change in patch 1, your patch 2 is very reasonable. It is admitting that "git remote" is really about tweaking the default remote config, and punting on config that doesn't appear to follow it. And doing it consistently. I don't think there's nothing wrong with that.

-Peff
Previous: Martin von ZweigbergkNext: Jeff King
Message 5 of 8 in “remote: write correct fetch spec when renaming remote 'remote'”
  1. 1/2 remote: write correct fetch spec when renaming remote 'remote'Martin von Zweigbergk, Sep 1, 2011
  2. 2/2 remote: "rename o foo" should not rename ref "origin/bar"Martin von Zweigbergk, Sep 1, 2011
  3. Jeff KingSep 1, 2011
  4. Martin von ZweigbergkSep 2, 2011
  5. Jeff KingSep 2, 2011
  6. Jeff KingSep 1, 2011
  7. Junio C HamanoSep 1, 2011
  8. Martin von ZweigbergkSep 2, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.