git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH RFC] gitk: Allow commit editing

From
Jeff King <peff@peff.net>
Date
Aug 25, 2011, 03:07 UTC
Message-ID
<20110825030755.GA3465@sigill.intra.peff.net>
In-Reply-To
<87obzlwpx0.fsf@steelpick.2x.cz>
On Fri, Aug 19, 2011 at 02:23:39PM +0200, Michal Sojka wrote:
Show 10 quoted lines
> > Invoking rebase behind the scenes makes me very nervous. In particular:
> > 
> >   1. There is nothing to indicate to the user that they are rewriting a
> >      string of commits, which is going to wreak havoc if any of the
> >      commits have been published elsewhere (either pushed somewhere, or
> >      even present in another local branch). I.e., rebasing generally
> >      needs to be a conscious decision of the user.
> 
> I added a warning if the edited commit is contained in a remote branch.
> Would you consider this sufficient?

It's likely problematic if the commit appears in the history of any other ref, unless they are also planning on rebasing that ref, too (which you can't really know, but it is probably better to warn).

-Peff
Previous: Michal Sojka
Message 10 of 10 in “Re: [PATCH RFC] gitk: Allow commit editing”
  1. Michal SojkaAug 19, 2011
  2. gitk: Allow commit editingMichal Sojka, Aug 19, 2011
  3. Jeff KingAug 25, 2011
  4. Michal SojkaAug 25, 2011
  5. Jeff KingAug 25, 2011
  6. gitk: Allow commit editingMichal Sojka, Aug 27, 2011
  7. Jeff KingSep 7, 2011
  8. Paul MackerrasSep 8, 2011
  9. Michal SojkaSep 13, 2011
  10. Jeff KingAug 25, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.