git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] get_indexed_object can return NULL if nothing is in that slot; check for it

From
Brian Harring <ferringb@gmail.com>
Date
Aug 24, 2011, 20:40 UTC
Message-ID
<20110824204021.GA28157@beast>
In-Reply-To
<7vmxeypudw.fsf@alter.siamese.dyndns.org>
On Wed, Aug 24, 2011 at 10:54:51AM -0700, Junio C Hamano wrote:
Show 6 quoted lines
> Thanks for a fix.
> 
> It is both interesting and disturbing to see that these small mistakes are
> discovered a week after the topics hit 'master', even though it has been
> cooking in 'next' for a week before that happened (in the case of this
> topic, it also hit 'maint' yesterday).

I'll admit I'm slightly surprised it slipped past for initial development- that said, you have to explicitly trigger the race to trigger the segfault. And that's not easy w/out building out a custom setup- even w/ that setup, you need to go digging in server logs to realize the previous serverside failure just converted to a segfault. Clientside, it hung just the same.

Bit nonobvious.  Plus, shit happens. ;)

Either way, I was poking at the source trying to figure out how to get some unittests for an end to end testing of the http/smartserv; that said I was having a helluva time finding a way to do it without bundling a stub of a webserver. Suggestions would be welcome on that one.

~brian
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 4 in “get_indexed_object can return NULL if nothing is in that slot; check for it”
  1. get_indexed_object can return NULL if nothing is in that slot; check for itBrian Harring, Aug 24, 2011
  2. Junio C HamanoAug 24, 2011
  3. Brian HarringAug 24, 2011
  4. Junio C HamanoAug 24, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.