git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rebase -i: clean error message for --continue after failed exec

From
Jeff King <peff@peff.net>
Date
Aug 24, 2011, 20:22 UTC
Message-ID
<20110824202233.GB28900@sigill.intra.peff.net>
In-Reply-To
<20110824202027.GA28900@sigill.intra.peff.net>
On Wed, Aug 24, 2011 at 04:20:27PM -0400, Jeff King wrote:
> Certainly my only user has ever been "exec make test". But I wonder if
Er, s/user/use.
> somebody is crazy enough to auto-generate some content and commit it.
> OTOH, shouldn't it then be their responsibility to make the commit?
> I.e., I can see at least the potential for mucking with the index, but I
> really don't see a reason for _leaving_ the index in a mucked state.

Having just read your followup patch, it looks sane. Exec commands are free to do whatever they like with the index as long as it is left in a clean state. That keeps the door open for semi-sane use cases, but will catch unintended index manipulation.

-Peff
Previous: Jeff King
Message 9 of 9 in “rebase -i: Should --continue auto-amend after failed exec?”
  1. Johannes SixtAug 8, 2011
  2. Matthieu MoyAug 24, 2011
  3. rebase -i: clean error message for --continue after failed execMatthieu Moy, Aug 24, 2011
  4. Junio C HamanoAug 24, 2011
  5. Junio C HamanoAug 24, 2011
  6. Matthieu MoyAug 25, 2011
  7. Johannes SixtAug 25, 2011
  8. Jeff KingAug 24, 2011
  9. Jeff KingAug 24, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.