git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/4] git-p4: Allow setting rename/copy detection threshold.

From
PWPete Wyckoff <pw@padd.com>
Date
Aug 20, 2011, 11:19 UTC
Message-ID
<20110820111956.GA5893@arf.padd.com>
In-Reply-To
<CAOpHH-WJWxeTSO5Dy6UR9pJh3w9hQSBuE7O1mY2KDAEsS9OAPw@mail.gmail.com>
vitor.hda@gmail.com wrote on Fri, 19 Aug 2011 14:51 +0100:
Show 14 quoted lines
> On Fri, Aug 19, 2011 at 12:47 PM, Pete Wyckoff <pw@padd.com> wrote:
> > I think you have to decide that 1 means 1 in this case.
> > Everything else can mean true.  That may suggest that using
> > --bool or --bool-or-int isn't possible in this case.
> 
> But doing that kind of post-processing would require me to call
> git-config (at least) twice: first to check if it is a number with a
> possible "." in the middle or "%" at the end and a second time with
> the --bool option. I have no problem in doing this, but I think it
> increases the complexity without bringing major advantages.
> 
> I will use --bool for detectCopiesHarder and will send you the new set
> of patches tonight, unless we decide to also start using it for
> detectCopies and detectRenames.

I was imagining you would not use "--bool", and parse everything yourself. But I see your point, and letting "1" mean "-M1" as opposed to "-M" is probably okay too. I'm not particularly worked up about which way that goes.

		-- Pete
Previous: Vitor AntunesNext: Vitor Antunes
Message 7 of 12 in “Support threshold in copy/rename detection”
  1. 0/4 Support threshold in copy/rename detectionVitor Antunes, Aug 18, 2011
  2. 1/4 git-p4: Allow setting rename/copy detection threshold.Vitor Antunes, Aug 18, 2011
  3. Junio C HamanoAug 18, 2011
  4. Vitor AntunesAug 18, 2011
  5. Pete WyckoffAug 19, 2011
  6. Vitor AntunesAug 19, 2011
  7. Pete WyckoffAug 20, 2011
  8. Vitor AntunesAug 22, 2011
  9. 2/4 git-p4: Add description of rename/copy detection options.Vitor Antunes, Aug 18, 2011
  10. 3/4 git-p4: Add test case for rename detection.Vitor Antunes, Aug 18, 2011
  11. 4/4 git-p4: Add test case for copy detection.Vitor Antunes, Aug 18, 2011
  12. Pete WyckoffAug 20, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.