git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/10] color and pager improvements

From
Jeff King <peff@peff.net>
Date
Aug 18, 2011, 04:58 UTC
Message-ID
<20110818045821.GA17377@sigill.intra.peff.net>

While looking at the pager and color code today, I decided to tackle two long-standing bugs, which entailed a lot of refactoring of the color code. The result fixes some minor bugs, and is a little nicer for calling code to use.

  [01/10]: t7006: modernize calls to unset
  [02/10]: test-lib: add helper functions for config
  [03/10]: t7006: use test_config helpers

These three are just cleanup I noticed before adding new tests to t7006; I hope that the helpers in 02/10 will be useful in a lot of other places, though.

  [04/10]: setup_pager: set GIT_PAGER_IN_USE
This fixes Ingo's problem from:
  http://article.gmane.org/gmane.comp.version-control.git/179430
Namely that:
  git -p stash show
fails to use colors properly.
  [05/10]: diff: refactor COLOR_DIFF from a flag into an int
  [06/10]: git_config_colorbool: refactor stdout_is_tty handling
  [07/10]: color: delay auto-color decision until point of use
These three fix the problem Steffen mentioned here:
  http://article.gmane.org/gmane.comp.version-control.git/177792

Namely that pager.color doesn't work in many cases. This has been a problem for years, but spread due to some pager-ordering changes late last year (see the comments in 07/10). I actually wonder if anyone is really using pager.color, as we haven't seen many complaints about it.

  [08/10]: config: refactor get_colorbool function
  [09/10]: diff: don't load color config in plumbing
  [10/10]: want_color: automatically fallback to color.ui

These three are refactoring that is made possible by 07/10. I think they make the code cleaner, and hopefully the diffstat of 10/10 speaks for itself.

-Peff
Next: Jeff King
Message 1 of 37 in “color and pager improvements”
  1. 0/10 color and pager improvementsJeff King, Aug 18, 2011
  2. 01/10 t7006: modernize calls to unsetJeff King, Aug 18, 2011
  3. Junio C HamanoAug 18, 2011
  4. 02/10 test-lib: add helper functions for configJeff King, Aug 18, 2011
  5. Junio C HamanoAug 18, 2011
  6. 03/10 t7006: use test_config helpersJeff King, Aug 18, 2011
  7. 04/10 setup_pager: set GIT_PAGER_IN_USEJeff King, Aug 18, 2011
  8. 05/10 diff: refactor COLOR_DIFF from a flag into an intJeff King, Aug 18, 2011
  9. 06/10 git_config_colorbool: refactor stdout_is_tty handlingJeff King, Aug 18, 2011
  10. 07/10 color: delay auto-color decision until point of useJeff King, Aug 18, 2011
  11. Junio C HamanoAug 18, 2011
  12. Jeff KingAug 18, 2011
  13. 08/10 config: refactor get_colorbool functionJeff King, Aug 18, 2011
  14. 09/10 diff: don't load color config in plumbingJeff King, Aug 18, 2011
  15. 10/10 want_color: automatically fallback to color.uiJeff King, Aug 18, 2011
  16. Martin von ZweigbergkSep 4, 2011
  17. Jeff KingSep 4, 2011
  18. Steffen Daode NurpmesoSep 5, 2011
  19. Jeff KingAug 18, 2011
  20. 11/10 support pager.* for aliasesJeff King, Aug 18, 2011
  21. Junio C HamanoAug 18, 2011
  22. Jeff KingAug 19, 2011
  23. Junio C HamanoAug 19, 2011
  24. Jeff KingAug 19, 2011
  25. Junio C HamanoAug 19, 2011
  26. Junio C HamanoAug 19, 2011
  27. Jeff KingAug 19, 2011
  28. 12/10 support pager.* for external commandsJeff King, Aug 18, 2011
  29. Junio C HamanoAug 18, 2011
  30. Ævar Arnfjörð BjarmasonFeb 12, 2012
  31. Jeff KingFeb 14, 2012
  32. Ingo BrücklAug 18, 2011
  33. Jeff KingAug 18, 2011
  34. Ingo BrücklAug 19, 2011
  35. Jeff KingAug 25, 2011
  36. Steffen Daode NurpmesoAug 18, 2011
  37. Junio C HamanoAug 18, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.