Re: [PATCH 4/5] sequencer: Expose code that handles files in .git/sequencer
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Aug 10, 2011, 15:21 UTC
- Message-ID
- <20110810152126.GE31315@elie.gateway.2wire.net>
- In-Reply-To
- <1312970151-18906-5-git-send-email-artagnon@gmail.com>
Hi,
Ramkumar Ramachandra wrote:
Show 33 quoted lines
> --- a/sequencer.h
> +++ b/sequencer.h
> @@ -38,6 +38,17 @@ struct replay_insn_list {
> struct replay_insn_list *next;
> };
>
> +/* Unrelated commit_message helper */
> +struct commit_message {
> + char *parent_label;
> + const char *label;
> + const char *subject;
> + char *reencoded_message;
> + const char *message;
> +};
> +
> +int get_commit_message(struct commit *commit, struct commit_message *out);
> +
> /*
> * Removes SEQ_OLD_DIR and renames SEQ_DIR to SEQ_OLD_DIR, ignoring
> * any errors. Intended to be used by 'git reset'.
> @@ -48,4 +59,14 @@ struct replay_insn_list {
> */
> void remove_sequencer_state(int aggressive);
>
> +struct replay_insn_list **replay_insn_list_append(enum replay_action action,
> + struct commit *operand,
> + struct replay_insn_list **next);
> +void sequencer_read_todo(struct replay_insn_list **todo_list);
> +void sequencer_read_opts(struct replay_opts **opts_ptr);
> +int sequencer_create_dir(void);
> +void sequencer_save_head(const char *head);
> +void sequencer_save_todo(struct replay_insn_list *todo_list);
> +void sequencer_save_opts(struct replay_opts *opts);This looks wrong. What is the expected calling sequence? Would it be possible to expose fewer functions by moving more to sequencer.c?