Re: [PATCH v2 2/2] Move git-dir for submodules

From: Heiko Voigt <hvoigt@hvoigt.net>
Date: Aug 9, 2011, 18:23 UTC
Message-ID: <20110809182332.GD42153@book.hvoigt.net>
In-Reply-To: <7v1uwvwpsk.fsf@alter.siamese.dyndns.org>

Hi,

On Mon, Aug 08, 2011 at 02:34:35PM -0700, Junio C Hamano wrote:

Show 21 quoted lines

> Heiko Voigt <hvoigt@hvoigt.net> writes:
> 
> > Hi,
> >
> > On Mon, Aug 08, 2011 at 09:17:02PM +0200, Fredrik Gustafsson wrote:
> >> diff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh
> >> index c679f36..1ae6b4e 100755
> >> --- a/t/t7406-submodule-update.sh
> >> +++ b/t/t7406-submodule-update.sh
> >> @@ -408,6 +408,7 @@ test_expect_success 'submodule update exit immediately in case of merge conflict
> >>  	 test_cmp expect actual
> >>  	)
> >>  '
> >> +
> >
> > There is a whitespace error here which we seem to have overlooked. Junio
> > could you remove that?
> 
> Hmm, confused.
> 
> A blank between test would be the perfectly normal thing to see, no?

Yes indeed you are right I did just see the lonely new line here. I missed that a blank line was missing previously here.

Cheers Heiko