Re: [RFC] helping smart-http/stateless-rpc fetch race
- From
- Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
- Date
- Aug 8, 2011, 23:08 UTC
- Message-ID
- <20110808230812.GA16974@LK-Perkele-VI.localdomain>
- In-Reply-To
- <CAGdFq_i=8p4jvKo1C=UFpmQyPtUd9JOtr9VW8vn7viC0dQkQmg@mail.gmail.com>
On Mon, Aug 08, 2011 at 11:05:27PM +0200, Sverre Rabbelier wrote:
Show 8 quoted lines
> Heya, > > On Mon, Aug 8, 2011 at 19:13, Junio C Hamano <gitster@pobox.com> wrote: > >> (1) It might make sense to give admins who run upload-pack not behind > >> smart-http an option to allow fetching from a non-tip; and > > You said earlier it isn't needed since the server process caches the > refs for git and ssh, that leaves dumb-http right?
It seems that everything currently possible falls into three categories:
1) Stateful upload-pack (git://, file://, ssh://, CONNECT): No fix needed. 2) Stateless upload-pack (smart http://, some bizarre helper): Needs fix to avoid races. 3) Dumb protocols (dumb http://, ftp://, rsync://): Won't invoke upload-pack anyway, no fix needed.
So I think that the only thing that needs the option to allow fetching from non-tips is anything using --stateless-rpc.
-Ilari