git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/4] git-p4: one test missing config git-p4.skipSubmitEditCheck

From
PWPete Wyckoff <pw@padd.com>
Date
Aug 7, 2011, 13:35 UTC
Message-ID
<20110807133548.GC27737@arf.padd.com>
In-Reply-To
<20110807133144.GA27521@arf.padd.com>

Add this missing line in one of the tests. Otherwise, on fast machines, the following git-p4 commit will complain that nobody edited the submission message.

Signed-off-by: Pete Wyckoff <pw@padd.com>
Acked-by: Luke Diamand <luke@diamand.org>
---
 t/t9800-git-p4.sh |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/t/t9800-git-p4.sh b/t/t9800-git-p4.sh
index b7eda82..b304707 100755
--- a/t/t9800-git-p4.sh
+++ b/t/t9800-git-p4.sh
@@ -191,6 +191,7 @@ test_expect_success 'refuse to preserve users without perms' '
 	"$GITP4" clone --dest="$git" //depot &&
 	test_when_finished cleanup_git &&
 	cd "$git" &&
+	git config git-p4.skipSubmitEditCheck true &&
 	echo "username-noperms: a change by alice" >> file1 &&
 	git commit --author "Alice <alice@localhost>" -m "perms: a change by alice" file1 &&
 	! P4EDITOR=touch P4USER=bob P4PASSWD=secret "$GITP4" commit --preserve-user &&
-- 
1.7.5.4
Previous: Pete WyckoffNext: Pete Wyckoff
Message 4 of 5 in “git-p4 test cleanup, commit time change”
  1. 0/4 git-p4 test cleanup, commit time changePete Wyckoff, Aug 7, 2011
  2. 1/4 git-p4: use test_when_finished in testsPete Wyckoff, Aug 7, 2011
  3. 2/4 git-p4: add missing && in testPete Wyckoff, Aug 7, 2011
  4. 3/4 git-p4: one test missing config git-p4.skipSubmitEditCheckPete Wyckoff, Aug 7, 2011
  5. 4/4 git-p4: commit time should be most recent p4 change timePete Wyckoff, Aug 7, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.