Re: [PATCH 03/40] whitespace: remediate t1006-cat-file.sh

On Sat, Aug 06, 2011 at 06:44:17PM +1000, Jon Seymour wrote:

Yes, this indent with spaces violates our coding style policy. However, the 4-space indentation does, too (and the space between function name and parentheses). The "right" way is according to our policy is:

  maybe_remove_timestamp() {
          if test -z "$2"; then
                  echo_without_newline "$1"

So I have to wonder if this automated indentation is really worthwhile. The result still doesn't meet our whitespace criteria (and I am slightly dubious that it is possible to write an accurate general-purpose indenter for shell code).

I suppose you could argue that even taking it partway towards right is better than nothing. But I get the feeling that nobody is really looking at this code; if they were, they would fix the style while they were there. And if not, then who cares if it's 10% right or 30% right?

I dunno. I'm not against a one-time cleanup, but I think making the cleanup script a part of the repo is kind of silly. Between git's whitespace warnings (which I suspect post-date most of these changes) and code review (which we need to catch non-automated style violations, in addition to regular bugs, of course), it seems like we already have a better solution in place. It's just that nobody has bothered to clean up the old code.

-Peff