Re: git-fast-export is returning streams with source code inside

From: Jeff King <peff@peff.net>
Date: Aug 5, 2011, 09:36 UTC
Message-ID: <20110805093618.GA19062@sigill.intra.peff.net>
In-Reply-To: <CAFC9htyFKm7NCNFvrUkxXpmj1jwatWkxrnRSEdztY4Syo+EQ-g@mail.gmail.com>

On Fri, Aug 05, 2011 at 10:24:07AM +0100, James Gregory wrote:

> I've attached the valgrind.out file. If I'm reading the output
> properly, it does look like it is suffering from a memory leak.

It looks pretty innocuous:

Show 13 quoted lines

> ==3267== Conditional jump or move depends on uninitialised value(s)
> ==3267==    at 0x4E39510: inflateReset2 (in /lib/x86_64-linux-gnu/libz.so.1.2.3.4)
> ==3267==    by 0x4E39605: inflateInit2_ (in /lib/x86_64-linux-gnu/libz.so.1.2.3.4)
> ==3267==    by 0x4D5B02: ??? (in /usr/bin/git)
> ==3267==    by 0x4BB059: ??? (in /usr/bin/git)
> ==3267==    by 0x4BC464: ??? (in /usr/bin/git)
> ==3267==    by 0x4BCA29: ??? (in /usr/bin/git)
> ==3267==    by 0x4BCAFD: ??? (in /usr/bin/git)
> ==3267==    by 0x4BD161: ??? (in /usr/bin/git)
> ==3267==    by 0x49AEAC: ??? (in /usr/bin/git)
> ==3267==    by 0x4B38AA: ??? (in /usr/bin/git)
> ==3267==    by 0x4B422A: ??? (in /usr/bin/git)
> ==3267==    by 0x4A9CD2: ??? (in /usr/bin/git)

This is a well-known false positive caused by zlib, and is nothing to worry about.

> ==3267== LEAK SUMMARY:
> ==3267==    definitely lost: 48,016 bytes in 3 blocks
> ==3267==    indirectly lost: 30,226 bytes in 1,889 blocks

These are actual leaks, but minor.

> ==3267==      possibly lost: 0 bytes in 0 blocks
> ==3267==    still reachable: 2,743,134 bytes in 4,334 blocks

These are not really leaks, but rather things we don't bother cleaning up since we're about to exit and let the OS reclaim memory (e.g., all of the commit objects).

So yes, there's leaking, but it's not much. And more importantly, I was looking not for leaks, but for memory access errors (of which there are none, except for the zlib false positive).

So I'm not sure where to go from here. I can't reproduce the problem locally. Is there anything else you can tell us about the problem? Does it always happen on the same commit? If you export just that commit, does the problem happen? Is there anything noteworthy in the contents of that commit?

-Peff