Re: [PATCH 1/2] gitattributes: Clarify discussion of attribute macros
- From
Jeff King <peff@peff.net>
- Date
- Aug 3, 2011, 22:40 UTC
- Message-ID
- <20110803224032.GA31153@sigill.intra.peff.net>
- In-Reply-To
- <7v1ux2b2d8.fsf@alter.siamese.dyndns.org>
On Wed, Aug 03, 2011 at 02:40:19PM -0700, Junio C Hamano wrote:
Show 7 quoted lines
> Jeff King <peff@peff.net> writes: > > > I don't know if that was intentional, or if the behavior is simply > > accidental and the original code was simply never meant to have > > "-binary" called at all. > > The latter. You were never expected to say -macro at all.
OK. Maybe we should flag an error, then? Or if not, then make the documentation more clear that it's not allowed (or even say the current behavior is reasonable, and document it).
-Peff