Re: [PATCH v15 5/7] bisect: introduce --no-checkout support into porcelain.

From: Christian Couder <chriscool@tuxfamily.org>
Date: Aug 3, 2011, 19:33 UTC
Message-ID: <201108032133.19854.chriscool@tuxfamily.org>
In-Reply-To: <CAH3Anrrt-FPqWmDhv0ucQfGKmgVbGLFBE5Pf8ma1LWroydNWLQ@mail.gmail.com>

On Wednesday 03 August 2011 17:32:09 Jon Seymour wrote:

Show 11 quoted lines

> On Thu, Aug 4, 2011 at 1:03 AM, Jon Seymour <jon.seymour@gmail.com> wrote:
>         rm -f "$GIT_DIR/head-name" &&
> 
> > -
> > -       rm -f "$GIT_DIR/BISECT_START"
> > +       rm -f "$GIT_DIR/BISECT_START" &&
> > +       git update-ref -d BISECT_HEAD
> >  }
> 
> I'll reverse the order of the last two statements and restore the blank
> line...

Great!

It would be nice too if the "git update-ref" call that creates the ref in the first place was after the creation of the $GIT_DIR/BISECT_START file. This way we start by creating the $GIT_DIR/BISECT_START file and we finish by deleting it.

That is change this:

...
+       test "$mode" != "--no-checkout" ||
+       git update-ref --no-deref BISECT_HEAD "$start_head" &&
        echo "$start_head" >"$GIT_DIR/BISECT_START" &&
 
into something like this:

        echo "$start_head" >"$GIT_DIR/BISECT_START" &&
+	{
+		test "$mode" != "--no-checkout" ||
+       	git update-ref --no-deref BISECT_HEAD "$start_head"
+	} &&
...

Thanks, Christian.