git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v14 5/8] bisect: introduce --no-checkout support into porcelain.

From
Christian Couder <chriscool@tuxfamily.org>
Date
Aug 3, 2011, 05:28 UTC
Message-ID
<201108030728.42453.chriscool@tuxfamily.org>
In-Reply-To
<7vk4avcsk9.fsf@alter.siamese.dyndns.org>
On Wednesday 03 August 2011 01:16:54 Junio C Hamano wrote:
Show 17 quoted lines
> 
> Having said that, other than these minor nits, I think this round is
> almost ready. I didn't check how it behaves upon "bisect reset",
> though. It shouldn't touch the index, HEAD nor the working tree (it
> probably is just the matter of "update-ref -d BISECT_HEAD" and nothing
> else, but I haven't thought things through thoroughly).
> 
> Further polishing we may want to do while it is still in pu/next I can
> think of off the top of my head are:
> 
>  - In this mode, I can bisect the history even inside a bare repository,
>    as the whole point of --no-checkout is that the mode does not require a
>    working tree. I however suspect "git bisect" requires working tree. Is
>    this something we want to fix?
> 
>  - Further, perhaps should we default to this mode inside a bare
>    repository?

I agree that it would be nice if it worked in a bare repo. I did not look at that yet.

> Christian, do you think of anything else?
No, I agree that it looks almost ready.
The few improvements I would like are:
- squashing the last patch into the previous ones,
- using a bisect_mode() function when needed.
> Also do you see flaws in our
> reasoning that updating only BISECT_HEAD and doing nothing else is a good
> way to do this?

No, I agree that --no-checkout is a good idea and that using only BISECT_HEAD is good way to do this.

Thanks, Christian.

Previous: Junio C HamanoNext: Jon Seymour
Message 9 of 20 in “bisect: Add support for --no-checkout option”
  1. 0/8 bisect: Add support for --no-checkout optionJon Seymour, Aug 2, 2011
  2. 1/8 bisect: move argument parsing before state modification.Jon Seymour, Aug 2, 2011
  3. 2/8 bisect: use && to connect statements that are deferred with eval.Jon Seymour, Aug 2, 2011
  4. 3/8 bisect: add tests to document expected behaviour in presence of broken trees.Jon Seymour, Aug 2, 2011
  5. 4/8 bisect: introduce support for --no-checkout option.Jon Seymour, Aug 2, 2011
  6. 5/8 bisect: introduce --no-checkout support into porcelain.Jon Seymour, Aug 2, 2011
  7. Junio C HamanoAug 2, 2011
  8. Junio C HamanoAug 2, 2011
  9. Christian CouderAug 3, 2011
  10. Jon SeymourAug 3, 2011
  11. Jon SeymourAug 3, 2011
  12. Junio C HamanoAug 3, 2011
  13. Jonathan NiederAug 3, 2011
  14. Jon SeymourAug 3, 2011
  15. Jonathan NiederAug 3, 2011
  16. Christian CouderAug 3, 2011
  17. 6/8 bisect: add tests for the --no-checkout option.Jon Seymour, Aug 2, 2011
  18. 7/8 bisect: add documentation for --no-checkout option.Jon Seymour, Aug 2, 2011
  19. 8/8 bisect: change bisect function to update BISECT_HEAD, rather than HEAD.Jon Seymour, Aug 2, 2011
  20. Christian CouderAug 3, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.