Re: [PATCH 2/2] git-gui blame add more common search hotkeys

From: David Fries <david@fries.net>
Date: Jul 20, 2011, 02:56 UTC
Message-ID: <20110720025601.GE26701@spacedout.fries.net>
In-Reply-To: <87sjq2cp8t.fsf@fox.patthoyts.tk>

On Tue, Jul 19, 2011 at 03:35:30PM +0100, Pat Thoyts wrote:

Show 7 quoted lines

> David Fries <david@fries.net> writes:
> 
> That aside, the goto-line feature works fine for me. I don't think the
> n, Shift-n binding is working though. When I have the focus in the blame
> window and enter 'n' it tries to add an 'n' to the text in the search
> box. The use of Enter and Shift-Enter makes sense and works as I
> expect. So I will drop the 'n' and 'Shift-n' bindings I think.

I have some 6000 some line files that I was preparing change sets and was needing to jump to a specific line. That's what prompted me to add the goto feature, I just went ahead and added the search hotkeys while I was in looking at it. I apparently didn't do enough testing on the search, it's <Key-N> not the <Shift-Key-n> that I had in there. The n and N only work when the search bar is dismissed with escape or something. I'm more used to vi's searching where the search field is dismissed with return and there isn't a search field left to add to. I'm fine with dropping the n/N bindings.

Show 8 quoted lines

> The -accelerator field on a menu specifies the text to show. Its more
> usual to show "Ctrl-G" than "Control-Key-G" here so I'll adjust that as
> well. The 'bind' command actually ties up the key binding to the menu
> action.
> 
> With the above changes, I'll apply this to git-gui's master (which lives
> at repo.or.cz/git-gui.git) and it will get merged into git on the next
> merge.

Sounds good, thanks for merging it.

-- 
David Fries <david@fries.net>    PGP pub CB1EE8F0
http://fries.net/~david/