Re: [PATCH 17/17] revert: Introduce --continue to continue the operation
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Jul 18, 2011, 20:09 UTC
- Message-ID
- <20110718200943.GB6657@elie.gateway.2wire.net>
- In-Reply-To
- <CALkWK0mfRR4M_VRQbpXzM97i4-fjF9=S+xPpCuwL-EQmaA9jfw@mail.gmail.com>
Ramkumar Ramachandra wrote:
> Jonathan Nieder writes:
Show 6 quoted lines
>> Hmm, I thought I remembered this coming up previously and Junio >> mentioning that it was intentional (maybe in the context of >> CHERRY_HEAD?), but I haven't been able to find the relevant message. > > Hm, not automatically signing off on a commit resolution. I'm not > sure I understand why.
Well, "intentional" doesn't mean "good behavior". I've already said I don't like it. :) If you remind me, I'll write a patch to make the sign-off from cherry-pick -s persist.
[...]
> Wait.
Thanks for a nice explanation. The detail that seems to be missing is that the meaning of --signoff is intended to be per-project. In some projects, it might represent "I reviewed this" or something else rather than the developer's certificate of origin.