Re: [RFC/PATCH] Changed gitweb.remote_heads config key name to gitweb.remoteHeads.

From: Jakub Narebski <jnareb@gmail.com>
Date: Jul 7, 2011, 20:36 UTC
Message-ID: <201107072236.51183.jnareb@gmail.com>
In-Reply-To: <201107072056.25417.jnareb@gmail.com>

> -- >8 --
> From: Jakub Narebski <jnareb@gmail.com>
> Date: Thu, 7 Jul 2011 20:48:50 +0200
> Subject: [PATCH] gitweb: Make git config search case insensitive

I should have probably add here the following:

  The section and key part of fully qualified name of config variable
  are case insensitive in git.  "git config --list -z" that gitweb uses
  returns them lowercased.

Show 7 quoted lines

> Gitweb does not (yet?) use git config variables with subsection, so we
> can simply lowercase $key in git_get_project_config: section name and
> key name are case insensitive (only subsection name is case
> sensitive).
> 
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---

Yet another case where commit message is longer than fix... ;-)

Show 19 quoted lines

>  gitweb/gitweb.perl |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 589c85b..59147b6 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -2526,6 +2526,7 @@ sub git_get_project_config {
>  
>  	# key sanity check
>  	return unless ($key);
> +	$key = lc($key); # assuming there is no subsection
>  	$key =~ s/^gitweb\.//;
>  	return if ($key =~ m/\W/);
>  
> -- 
> 1.7.5
> 
>

-- 
Jakub Narebski
Poland