git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] git-svn: New flag to emulate empty directories

From
EWEric Wong <normalperson@yhbt.net>
Date
Jun 28, 2011, 04:23 UTC
Message-ID
<20110628042324.GA29123@dcvr.yhbt.net>
In-Reply-To
<loom.20110601T231627-922@post.gmane.org>

Sorry, I got tied up with other things for a while. Feel free to remind me after a week or so if I don't respond, too.

Ray Chen <rchen@cs.umd.edu> wrote:
> Is there anything I can do to make this patch more palatable for inclusion?

I would like the config option to be "sticky" like the "--ignore-paths" option when used with clone and saved to the config file. This can be done inside do_git_init_db().

In shell scripts, use $(command) instead of `command` in shell scripts as suggested in Documentation/CodingStyle.

Otherwise, things look mostly alright and I'm inclined to accept your patch. An extra reviewer would also be helpful since I very rarely use git-svn nowadays.

-- 
Eric Wong
Previous: Ray Chen
Message 3 of 3 in “git-svn: New flag to emulate empty directories”
  1. git-svn: New flag to emulate empty directoriesRay Chen, May 26, 2011
  2. Ray ChenJun 1, 2011
  3. Eric WongJun 28, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.