git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/4] git-instaweb: Use $conf, not $fqgitdir/gitweb/httpd.conf

From
Jakub Narebski <jnareb@gmail.com>
Date
Jun 23, 2011, 19:56 UTC
Message-ID
<20110623195516.18265.825.stgit@localhost.localdomain>
In-Reply-To
<20110623194624.18265.82482.stgit@localhost.localdomain>

Don't repeat yourself: use "$conf" instead of its [current] contents, namely "$fqgitdir/gitweb/httpd.conf".

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
Straighforward improvement.  Note that currently $conf is constant,
and doesn't change its value.
 git-instaweb.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-instaweb.sh b/git-instaweb.sh
index 49bab7b..2be22a0 100755
--- a/git-instaweb.sh
+++ b/git-instaweb.sh
@@ -103,7 +103,7 @@ start_httpd () {
 	case "$httpd" in
 	*mongoose*|*plackup*)
 		#These servers don't have a daemon mode so we'll have to fork it
-		$full_httpd "$fqgitdir/gitweb/httpd.conf" &
+		$full_httpd "$conf" &
 		#Save the pid before doing anything else (we'll print it later)
 		pid=$!
 
@@ -117,7 +117,7 @@ $pid
 EOF
 		;;
 	*)
-		$full_httpd "$fqgitdir/gitweb/httpd.conf"
+		$full_httpd "$conf"
 		if test $? != 0; then
 			echo "Could not execute http daemon $httpd."
 			exit 1
Previous: Jakub NarebskiNext: Jakub Narebski
Message 7 of 10 in “Having some problem with instaweb”
  1. Gurjeet SinghJun 23, 2011
  2. Jakub NarebskiJun 23, 2011
  3. Gurjeet SinghJun 23, 2011
  4. Jakub NarebskiJun 23, 2011
  5. 0/4 git-instaweb: Improving handling of --start/--restartJakub Narebski, Jun 23, 2011
  6. 1/4 git-instaweb: Extract configuring web server into configure_httpdJakub Narebski, Jun 23, 2011
  7. 2/4 git-instaweb: Use $conf, not $fqgitdir/gitweb/httpd.confJakub Narebski, Jun 23, 2011
  8. 3/4 git-instaweb: Move all actions at the end of scriptJakub Narebski, Jun 23, 2011
  9. 4/4 git-instaweb: Check that correct config file exists for (re)startJakub Narebski, Jun 23, 2011
  10. Eric WongJun 28, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.