Re: [PATCH 1/1] git-am: provide configuration to enable signoff by default

From: Jeff King <peff@peff.net>
Date: Jun 1, 2011, 16:39 UTC
Message-ID: <20110601163919.GC7132@sigill.intra.peff.net>
In-Reply-To: <1306917751-27999-1-git-send-email-nsekhar@ti.com>

On Wed, Jun 01, 2011 at 02:12:31PM +0530, Sekhar Nori wrote:

Show 5 quoted lines

> Provide a git config option to enable --signoff a
> default when using git-am. This should be handy
> for maintainers who regularly apply patches from
> mailing lists to send them upstream and want to
> be on the sign-off path.

I think people have complained about auto-signoff features before, because it was supposed to be a conscious act. I don't recall if it was ever resolved, and I don't have an opinion myself, but it may be worth searching the archives for past arguments.

Show 16 quoted lines

> diff --git a/git-am.sh b/git-am.sh
> index 6cdd591..8e2a693 100755
> --- a/git-am.sh
> +++ b/git-am.sh
> @@ -328,6 +328,11 @@ then
>      keepcr=t
>  fi
>  
> +if test "$(git config --bool --get am.signoff)" = true
> +then
> +    sign=t
> +fi
> +
>  while test $# != 0
>  do
>  	case "$1" in

Shouldn't this be turned off if --rebasing is passed? Otherwise you would introduce signoffs during rebase (I didn't check, though, so maybe there is some other mechanism preventing it).

-Peff