git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] gitk: Allow displaying time zones from author and commit timestamps

From
Paul Mackerras <paulus@samba.org>
Date
May 29, 2011, 04:46 UTC
Message-ID
<20110529044656.GA8881@brick.ozlabs.ibm.com>
In-Reply-To
<alpine.DEB.2.02.1101191447340.23868@dr-wily.mit.edu>
On Wed, Jan 19, 2011 at 02:47:52PM -0500, Anders Kaseorg wrote:
Show 23 quoted lines
> Now gitk can be configured to display author and commit dates in their
> original timezone, by putting %z into datetimeformat in ~/.gitk.
> 
> Signed-off-by: Anders Kaseorg <andersk@mit.edu>
> ---
>  gitk |   13 ++++++++++++-
>  1 files changed, 12 insertions(+), 1 deletions(-)
> 
> diff --git a/gitk b/gitk
> index 5c6058a..a072593 100755
> --- a/gitk
> +++ b/gitk
> @@ -11018,7 +11018,18 @@ proc prefsok {} {
>  proc formatdate {d} {
>      global datetimeformat
>      if {$d ne {}} {
> -	set d [clock format [lindex $d 0] -format $datetimeformat]
> +	if {[string match {*%[zZ]*} $datetimeformat]} {
> +	    if {[catch {set d [clock format [lindex $d 0] -timezone [lindex $d 1] -format $datetimeformat]}]} {
> +		# Tcl < 8.5 does not support -timezone.
> +		global env
> +		set zone [lindex $d 1]
> +		set env(TZ) "IDK[string range $zone 0 2]:[string range $zone 3 end]"

What is this about? Where is the IDK prefix for timezones defined or described?

> +		set d [clock format [lindex $d 0] -format $datetimeformat]
> +		unset env(TZ)
Oops, we just lost any previous setting of TZ...
Paul.
Previous: Anders KaseorgNext: Anders Kaseorg
Message 4 of 15 in “gitk: Remove unused $cdate array”
  1. 1/3 gitk: Remove unused $cdate arrayAnders Kaseorg, Jan 19, 2011
  2. 2/3 gitk: Remember time zones from author and commit timestampsAnders Kaseorg, Jan 19, 2011
  3. 3/3 gitk: Allow displaying time zones from author and commit timestampsAnders Kaseorg, Jan 19, 2011
  4. Paul MackerrasMay 29, 2011
  5. Anders KaseorgMay 30, 2011
  6. 3/3 gitk: Allow displaying time zones from author and commit timestampsAnders Kaseorg, May 30, 2011
  7. Andreas SchwabMay 30, 2011
  8. Anders KaseorgMay 30, 2011
  9. 3/3 gitk: Allow displaying time zones from author and commit timestampsAnders Kaseorg, May 30, 2011
  10. Jakub NarebskiMay 30, 2011
  11. Tim GuirgiesMay 30, 2011
  12. Jakub NarebskiMay 30, 2011
  13. Anders KaseorgMay 30, 2011
  14. Andreas SchwabMay 30, 2011
  15. 3/3 gitk: Allow displaying time zones from author and commit timestampsAnders Kaseorg, May 30, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.