git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Remove a dead assignment

From
CWChris Wilson <cwilson@vigilantsw.com>
Date
May 25, 2011, 18:45 UTC
Message-ID
<20110525184514.GA20005@localhost>
In-Reply-To
<4DDD3A01.6040407@elegosoft.com>
The assignment to fmt is dead and is also useless.
Signed-off-by: Chris Wilson <cwilson@vigilantsw.com>
---
On Wed, May 25, 2011 at 07:18:57PM +0200, Michael Schubert wrote:
> There already is a patch on its way:
> 
> http://article.gmane.org/gmane.comp.version-control.git/174378

Thanks! Well, I wasn't going to report this dead assignment since it wasn't done recently, but now I want to figure out how to properly submit a patch. :) Am I there yet? and thanks for the help.

Thanks, CHris

 pretty.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/pretty.c b/pretty.c
index dff5c8d..5667c7f 100644
--- a/pretty.c
+++ b/pretty.c
@@ -1082,7 +1082,6 @@ void userformat_find_requirements(const char *fmt, struct userformat_
        if (!fmt) {
                if (!user_format)
                        return;
-               fmt = user_format;
        }
        strbuf_expand(&dummy, user_format, userformat_want_item, w);
        strbuf_release(&dummy);
-- 
1.7.5.2.354.g19aea
Previous: Michael SchubertNext: Junio C Hamano
Message 7 of 10 in “Simple dead assignment”
  1. Chris WilsonMay 24, 2011
  2. Simple dead assignmentChris Wilson, May 24, 2011
  3. Matthieu MoyMay 25, 2011
  4. Remove a dead assignmentChris Wilson, May 25, 2011
  5. Matthieu MoyMay 25, 2011
  6. Michael SchubertMay 25, 2011
  7. Remove a dead assignmentChris Wilson, May 25, 2011
  8. Junio C HamanoMay 25, 2011
  9. Junio C HamanoMay 25, 2011
  10. Jeff KingMay 25, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.