Re: [PATCH] git-svn: enable platform-specific authentication

From: Eric Wong <normalperson@yhbt.net>
Date: May 18, 2011, 19:57 UTC
Message-ID: <20110518195710.GA10697@dcvr.yhbt.net>
In-Reply-To: <1305708320-8614-1-git-send-email-grddev@gmail.com>

Gustav Munkby <grddev@gmail.com> wrote:

> Use the platform-specific authentication providers that are
> exposed to subversion bindings starting with subversion 1.6.

This came up several months ago, I understand there were some issues with the SVN Perl bindings. Cc-ing interested parties.

Show 5 quoted lines

>  sub _auth_providers () {
>  	[
> +	  $SVN::Core::VERSION lt '1.6' ? () :
> +	    @{SVN::Core::auth_get_platform_specific_client_providers(
> +	      undef,undef)},

I think it needs to take into account the config from SVN::Core::config_get_config, otherwise people with non-standard SVN configurations could get locked out. I seem to recall this was the broken part in the SVN Perl bindings, but one of the Cc-ed parties would know for sure.

-- 
Eric Wong