Re: [PATCH/RFC] git-svn: New flag to add a file in empty directories

From: Eric Wong <normalperson@yhbt.net>
Date: May 18, 2011, 08:22 UTC
Message-ID: <20110518082215.GA21899@dcvr.yhbt.net>
In-Reply-To: <1305669635-10861-1-git-send-email-rchen@cs.umd.edu>

Ray Chen <rchen@cs.umd.edu> wrote:

> I needed this functionality when I was migrating a repository from SVN to
> Git.

This feature sounds reasonable for folks making one-shot or read-only mirrors with git svn.

> My knowledge of SVN is limited, so I'm not sure how correct this patch is.
> I created a little test SVN repo, and `git svn clone --preserve-empty-dirs`
> did the right thing, but that's hardly a complete test.

Please provide an automated test case so it's easier to review (I almost never see SVN repos anymore) and to ensure it stays working when other changes are made.

> Specifically, I experimentally noticed that my patch worked with lines 4532
> and 4533 commented out.  I'm not sure what problems might occur when adding
> a file Git without associated SVN properties.

These two lines?

Show 5 quoted lines

> +	# The following two lines don't seem to be necessary, but I'm not
> +	# familiar enough with SVN properties to know if correctness is
> +	# compromised without them.
> +#	$self->{file_prop}->{$path} = $self->{dir_prop}->{$dir};
> +#	$self->add_file($path, { 'path' => $dir }, undef, '-1');

It's been years since I dealt with the SVN library, so I'm not sure I still remember. I think add_file is only for files that exist in the SVN side, not sure about the file_prop/dir_prop assignment, either.

(more in my reply to Michael's email)

-- 
Eric Wong