Re: [PATCH v4 1/2] usage: Introduce error_errno corresponding to die_errno
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- May 8, 2011, 09:46 UTC
- Message-ID
- <20110508094608.GB18463@ramkum.desktop.amazon.com>
- In-Reply-To
- <1304839851-6477-2-git-send-email-artagnon@gmail.com>
Hi,
Ramkumar Ramachandra writes:
Show 5 quoted lines
> The error function always returns the constant value -1, and this does > not convey enough information about the nature of the error. This > patch introduces a new function error_errno that functions exactly > like the error function, except that it returns `errorno` instead of a > constant value.
An extra note: this could have been implemented differently, as seen in my sequencer series [1]. However, after some thought, I think this is how we want error handling to work. The name may be a little troubling because it doesn't behave like die_errno: does anyone have suggestions for a different name?
[1]: http://article.gmane.org/gmane.comp.version-control.git/171262
-- Ram