git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t1507: change quoting in test_did_you_mean to a more general one

From
Kacper Kornet <draenog@pld-linux.org>
Date
May 5, 2011, 19:10 UTC
Message-ID
<20110505191027.GA3242@camk.edu.pl>
In bash and some other shells the script:
x=2; unset a; echo "${a:-'$x'}"

prints '2'. However ksh shell prints $x. The quoting is added to reproduce bash behaviour.

Signed-off-by: Kacper Kornet <draenog@pld-linux.org>
---
 t/t1506-rev-parse-diagnosis.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t1506-rev-parse-diagnosis.sh b/t/t1506-rev-parse-diagnosis.sh
index 4a6396f..bad09f9 100755
--- a/t/t1506-rev-parse-diagnosis.sh
+++ b/t/t1506-rev-parse-diagnosis.sh
@@ -8,8 +8,8 @@ exec </dev/null
 
 test_did_you_mean ()
 {
-	printf "fatal: Path '$2$3' $4, but not ${5:-'$3'}.\n" >expected &&
-	printf "Did you mean '$1:$2$3'${2:+ aka '$1:./$3'}?\n" >>expected &&
+	printf "fatal: Path '$2$3' $4, but not ${5:-\'$3\'}.\n" >expected &&
+	printf "Did you mean '$1:$2$3'${2:+ aka \'$1:./$3\'}?\n" >>expected &&
 	test_cmp expected error
 }
 
-- 
1.7.5

-- 
  Kacper Kornet
Next: Junio C Hamano
Message 1 of 12 in “t1507: change quoting in test_did_you_mean to a more general one”
  1. t1507: change quoting in test_did_you_mean to a more general oneKacper Kornet, May 5, 2011
  2. Junio C HamanoMay 5, 2011
  3. Michael J GruberMay 6, 2011
  4. Kacper KornetMay 6, 2011
  5. Michael J GruberMay 6, 2011
  6. Johannes SixtMay 6, 2011
  7. Michael J GruberMay 6, 2011
  8. Junio C HamanoMay 6, 2011
  9. Junio C HamanoMay 9, 2011
  10. Johannes SixtMay 9, 2011
  11. Junio C HamanoMay 9, 2011
  12. Kacper KornetMay 6, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.