Re: [PATCH] blame: Improve parsing for emails with spaces

From: Jeff King <peff@github.com>
Date: Apr 29, 2011, 19:13 UTC
Message-ID: <20110429191355.GC27268@sigill.intra.peff.net>
In-Reply-To: <7vvcxxvsz4.fsf@alter.siamese.dyndns.org>

On Fri, Apr 29, 2011 at 10:59:43AM -0700, Junio C Hamano wrote:

Show 12 quoted lines

> > Hmm. That address seems bogus, and I wonder if we should be rejecting it
> > at commit time. Still, it is something we may run across in existing
> > repositories, so handling it more gracefully makes sense.
> 
> Perhaps but within reason.  
> 
> What new types of breakages are we proposing to tolerate, what breakages
> are we declaring not worth fixing, and what is the price of not loosening
> this?  Without this patch, such a broken commit will result in the author
> email shown somewhat broken, but the original is already broken to begin
> with, and also the entry for the blamed line will come with its commit
> object name anyway, so I do not think it is such a big deal.

I'm pretty sure such an address would make a non-rfc822-compliant "from" header when used with format-patch. But given that it is obviously a bogus address, I don't think there's much we can do anyway, and anyone looking at will say "Oh, that's wrong". So it's probably not a big deal.

-Peff